Fix topic name validation (#661)

* Fix topic name validation * Update wording
infinyon · Jan 10, 2021 · 8499f5c · 8499f5c
1 parent d3cb47d
commit 8499f5c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/extension-consumer/Cargo.toml b/src/extension-consumer/Cargo.toml
@@ -24,7 +24,7 @@ futures-lite = { version = "1.7.0" }
 thiserror = "1.0.20"
 eyre = "0.6.1"
 which = "4.0.2"
-
+hostname-validator = "1.0.0"
 
 # Fluvio dependencies
 

diff --git a/src/extension-consumer/src/topic/create.rs b/src/extension-consumer/src/topic/create.rs
@@ -121,11 +121,10 @@ impl CreateTopicOpt {
             })
         };
 
-        let is_alphanumeric =
-            self.topic.is_ascii() && self.topic.chars().all(|c| c.is_alphanumeric());
-        if !is_alphanumeric {
+        let is_valid = hostname_validator::is_valid(&self.topic);
+        if !is_valid {
             return Err(ConsumerError::InvalidArg(
-                "Topic name must be alphanumeric".to_string(),
+                "Topic name must only contain alphanumeric characters, '-', or '.'".to_string(),
             ));
         }