Skip to content

Commit

Permalink
fix: backward compatibility for SmartModuleKind (#3036)
Browse files Browse the repository at this point in the history
Fixes #3035
  • Loading branch information
Alexander Galibey committed Mar 1, 2023
1 parent ed17bb1 commit fd6fb06
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions crates/fluvio-spu-schema/src/server/smartmodule.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ pub enum SmartModuleKind {
},
#[fluvio(min_version = ARRAY_MAP_WASM_API)]
FilterMap,
#[fluvio(min_version = SMART_MODULE_API, max_version = CHAIN_SMARTMODULE_API)]
Join(String),
#[fluvio(min_version = SMART_MODULE_API, max_version = CHAIN_SMARTMODULE_API)]
JoinStream {
topic: String,
derivedstream: String,
},
#[fluvio(min_version = GENERIC_SMARTMODULE_API)]
Generic(SmartModuleContextData),
}
Expand All @@ -106,6 +113,8 @@ impl std::fmt::Display for SmartModuleKind {
SmartModuleKind::ArrayMap => "array_map",
SmartModuleKind::Aggregate { .. } => "aggregate",
SmartModuleKind::FilterMap => "filter_map",
SmartModuleKind::Join(..) => "join",
SmartModuleKind::JoinStream { .. } => "join_stream",
SmartModuleKind::Generic(..) => "smartmodule",
};
out.write_str(name)
Expand Down

2 comments on commit fd6fb06

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fd6fb06 Previous: 7a58d66 Ratio
encode wasm file 293316 ns/iter (± 32916) 347897 ns/iter (± 39717) 0.84

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fd6fb06 Previous: 7a58d66 Ratio
vecu8 encoding 505262 ns/iter (± 45850) 382067 ns/iter (± 719271) 1.32
vecu8 decoding 532716 ns/iter (± 5621) 594623 ns/iter (± 30935) 0.90
bytebuf encoding 8257 ns/iter (± 93) 15353 ns/iter (± 636) 0.54
bytebuf decoding 14412 ns/iter (± 2648) 15429 ns/iter (± 603) 0.93

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.