Added tests.

infobip · Nov 5, 2024 · 9376c5b · 9376c5b
1 parent 872f547
commit 9376c5b
Show file tree

Hide file tree

Showing 8 changed files with 1,214 additions and 1,294 deletions.
diff --git a/ApiClient.Tests/ApiExceptionTest.cs b/ApiClient.Tests/ApiExceptionTest.cs
@@ -74,7 +74,7 @@ public void ErrorResponseTest(int errorResponseIndex)
             Dictionary<string, string> responseHeaders = new Dictionary<string, string>()
             {
                 { "Server", "SMS,API" },
-                { "X-Request-ID", "1234567898765432100" },
+                { "X-Request-ID", "1608758729810312842" },
                 { "Content-Type", "application/json; charset=utf-8" }
             };
 

diff --git a/ApiClient.Tests/ApiTest.cs b/ApiClient.Tests/ApiTest.cs
diff --git a/ApiClient.Tests/DateTimeSerializationTest.cs b/ApiClient.Tests/DateTimeSerializationTest.cs
@@ -36,15 +36,12 @@ public class DateTimeSerializationTest
         [DataTestMethod]
         public void DateTimeFormatDeserializationTest(string dateString, int dateValueIndex)
         {
-            // ARRANGE
             DateTimeOffset expected = DateTimeValues[dateValueIndex];
 
             string jsonDate = $"{{\"date\":\"{dateString}\"}}";
 
-            // ACT
-            TestObject actual = JsonConvert.DeserializeObject<TestObject>(jsonDate);
+            TestObject actual = JsonConvert.DeserializeObject<TestObject>(jsonDate)!;
 
-            // ASSERT
             Assert.AreEqual(expected, actual.Date);
             Assert.AreEqual(expected.Ticks, actual.Date.Ticks);
             Assert.AreEqual(expected.Offset, actual.Date.Offset);
@@ -66,13 +63,10 @@ public void DateTimeFormatDeserializationTest(string dateString, int dateValueIn
         [DataTestMethod]
         public void DateTimeFormatSerializationTest(int dateValueIndex, string expected)
         {
-            // ARRANGE
             DateTimeOffset initialDate = DateTimeValues[dateValueIndex];
 
-            // ACT
             string actual = JsonConvert.SerializeObject(initialDate);
 
-            // ASSERT
             Assert.AreEqual($"\"{expected}\"", actual);
         }
 

diff --git a/ApiClient.Tests/EmailApiTest.cs b/ApiClient.Tests/EmailApiTest.cs
diff --git a/ApiClient.Tests/GeneralSetupTest.cs b/ApiClient.Tests/GeneralSetupTest.cs
@@ -13,9 +13,9 @@ public class GeneralSetupTest : ApiTest
         protected const string SMS_SEND_TEXT_ADVANCED_ENDPOINT = "/sms/2/text/advanced";
 
         [TestMethod]
-        public void UsingExampleFromDocs() // Here is for debugging only
+        public void UsingExampleFromDocs()
         {
-            string expectedRequest = @"
+            string givenRequest = @"
             {
                 ""messages"": [
                 {
@@ -48,20 +48,20 @@ public class GeneralSetupTest : ApiTest
               ]
             }";
 
-            SetUpPostRequest(SMS_SEND_TEXT_ADVANCED_ENDPOINT, new Dictionary<string, string> { { "param1", "val1" } }, expectedRequest, expectedResponse, 200);
+            SetUpPostRequest(SMS_SEND_TEXT_ADVANCED_ENDPOINT, new Dictionary<string, string> { { "param1", "val1" } }, givenRequest, expectedResponse, 200);
 
-            var client = new RestClient(configuration.BasePath + SMS_SEND_TEXT_ADVANCED_ENDPOINT);
-            client.UserAgent = "infobip-api-client-csharp/" + Configuration.Version;
-            client.Timeout = -1;
+            var client = new RestClient(configuration!.BasePath + SMS_SEND_TEXT_ADVANCED_ENDPOINT)
+            {
+                UserAgent = "infobip-api-client-csharp/" + Configuration.Version,
+                Timeout = -1
+            };
             var request = new RestRequest(Method.POST);
             request.AddHeader("Authorization", configuration.ApiKeyWithPrefix);
             request.AddHeader("Content-Type", "application/json; charset=utf-8");
             request.AddHeader("Accept", "application/json");
             request.AddQueryParameter("param1", "val1");
-            request.AddParameter("application/json", expectedRequest, ParameterType.RequestBody);
+            request.AddParameter("application/json", givenRequest, ParameterType.RequestBody);
             IRestResponse response = client.Execute(request);
-            //Console.WriteLine(response.Content);
-            Console.WriteLine(wireMockServer.LogEntries);
 
             Assert.IsNotNull(response);
             Assert.AreEqual(HttpStatusCode.OK, response.StatusCode);

diff --git a/ApiClient.Tests/SmsApiTest.cs b/ApiClient.Tests/SmsApiTest.cs
@@ -101,8 +101,6 @@ void SmsResponseAssertion(SmsResponse smsResponse)
 
             AssertResponseWithHttpInfo(smsApi.SendSmsMessageWithHttpInfo(smsRequest), SmsResponseAssertion);
             AssertResponseWithHttpInfo(smsApi.SendSmsMessageWithHttpInfoAsync(smsRequest).Result, SmsResponseAssertion);
-
-            //Console.WriteLine(wireMockServer.LogEntries);
         }
 
 
@@ -254,10 +252,6 @@ public void ShouldSendFullyFeaturedSmsMessage()
                 }}
             }}";
 
-            // TODO check if we need to emit default values for deliveryTimeWindow
-            //,
-            //""minute"": { givenDeliveryTimeFromMinuteMessage2}
-
             string givenBulkId = "BULK-ID-123-xyz";
             string givenTracking = "SMS";
             string givenTrackingType = "MY_CAMPAIGN";
@@ -401,9 +395,7 @@ public void ShouldSendFullyFeaturedBinaryMessage()
                 ""callbackData"": ""{givenCallbackDataMessage1}"",
                 ""validityPeriod"": {givenValidityPeriodMessage1}
             }}";
-            //,
-            //        ""dataCoding"": { givenDataCodingMessage1},
-            //        ""esmClass"": { givenEsmClassMessage1}
+
             string givenFromMessage2 = "41793026700";
             string givenToMessage2 = "41793026700";
             string givenHexMessage2 = "54 65 73 74 20 6d 65 73 73 61 67 65 2e";
@@ -453,9 +445,6 @@ public void ShouldSendFullyFeaturedBinaryMessage()
                 }}
             }}";
 
-            //,
-            //        ""dataCoding"": { givenDataCodingMessage2},
-            //        ""esmClass"": { givenEsmClassMessage2}
             string givenBulkId = "BULK-ID-123-xyz";
             int givenSendingSpeedLimitAmount = 10;
             string givenSendingSpeedLimitTimeUnitString = "HOUR";