Skip to content

Neutron client in pure rust #67

Neutron client in pure rust

Neutron client in pure rust #67

Triggered via pull request October 2, 2024 20:38
Status Skipped
Total duration 3s
Artifacts

e2e-tests.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L224
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:224:47 | 224 | .arg(format!("-Dgrpc_url={}", grpc_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L223
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:223:43 | 223 | .arg(format!("-Dws_url={}", ws_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L222
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:222:47 | 222 | .arg(format!("-Dnode_url={}", node_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default
this function has too many arguments (11/7): crates/cli/src/handler/enclave_start.rs#L185
warning: this function has too many arguments (11/7) --> crates/cli/src/handler/enclave_start.rs:185:1 | 185 | / async fn gramine_manifest( 186 | | trusted_height: &str, 187 | | trusted_hash: &str, 188 | | quartz_dir: &Path, ... | 196 | | grpc_url: &Url, 197 | | ) -> Result<(), Error> { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L224
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:224:47 | 224 | .arg(format!("-Dgrpc_url={}", grpc_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L223
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:223:43 | 223 | .arg(format!("-Dws_url={}", ws_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: crates/cli/src/handler/enclave_start.rs#L222
warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/cli/src/handler/enclave_start.rs:222:47 | 222 | .arg(format!("-Dnode_url={}", node_url.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default
this function has too many arguments (11/7): crates/cli/src/handler/enclave_start.rs#L185
warning: this function has too many arguments (11/7) --> crates/cli/src/handler/enclave_start.rs:185:1 | 185 | / async fn gramine_manifest( 186 | | trusted_height: &str, 187 | | trusted_hash: &str, 188 | | quartz_dir: &Path, ... | 196 | | grpc_url: &Url, 197 | | ) -> Result<(), Error> { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
large size difference between variants: crates/cli/src/cli.rs#L85
warning: large size difference between variants --> crates/cli/src/cli.rs:85:1 | 85 | / pub enum ContractCommand { 86 | | Build(ContractBuildArgs), | | ------------------------ the second-largest variant contains at least 24 bytes 87 | | Deploy(ContractDeployArgs), | | -------------------------- the largest variant contains at least 384 bytes 88 | | } | |_^ the entire enum is at least 384 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 87 | Deploy(Box<ContractDeployArgs>), | ~~~~~~~~~~~~~~~~~~~~~~~
large size difference between variants: crates/cli/src/cli.rs#L85
warning: large size difference between variants --> crates/cli/src/cli.rs:85:1 | 85 | / pub enum ContractCommand { 86 | | Build(ContractBuildArgs), | | ------------------------ the second-largest variant contains at least 24 bytes 87 | | Deploy(ContractDeployArgs), | | -------------------------- the largest variant contains at least 384 bytes 88 | | } | |_^ the entire enum is at least 384 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 87 | Deploy(Box<ContractDeployArgs>), | ~~~~~~~~~~~~~~~~~~~~~~~
this expression creates a reference which is immediately dereferenced by the compiler: crates/utils/cw-client/src/neutrond.rs#L199
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/utils/cw-client/src/neutrond.rs:199:35 | 199 | let tx_signed = sign_doc.sign(&secret)?; | ^^^^^^^ help: change this to: `secret` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
useless conversion to the same type: `cosmrs::crypto::PublicKey`: crates/utils/cw-client/src/neutrond.rs#L196
warning: useless conversion to the same type: `cosmrs::crypto::PublicKey` --> crates/utils/cw-client/src/neutrond.rs:196:54 | 196 | let signer_info = SignerInfo::single_direct(Some(tm_pubkey.into()), sequence_number); | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tm_pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/utils/cw-client/src/neutrond.rs#L131
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/utils/cw-client/src/neutrond.rs:131:13 | 131 | &chain_id, | ^^^^^^^^^ help: change this to: `chain_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/utils/cw-client/src/neutrond.rs#L199
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/utils/cw-client/src/neutrond.rs:199:35 | 199 | let tx_signed = sign_doc.sign(&secret)?; | ^^^^^^^ help: change this to: `secret` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
useless conversion to the same type: `cosmrs::crypto::PublicKey`: crates/utils/cw-client/src/neutrond.rs#L196
warning: useless conversion to the same type: `cosmrs::crypto::PublicKey` --> crates/utils/cw-client/src/neutrond.rs:196:54 | 196 | let signer_info = SignerInfo::single_direct(Some(tm_pubkey.into()), sequence_number); | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tm_pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default