Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): print-fmspc command #247

Merged
merged 14 commits into from
Oct 10, 2024
Merged

feat(cli): print-fmspc command #247

merged 14 commits into from
Oct 10, 2024

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Oct 8, 2024

Closes: #242

@hu55a1n1
Copy link
Member Author

hu55a1n1 commented Oct 8, 2024

Tested with both cargo run -- print-fmspc and quartz print-fmspc.

@hu55a1n1 hu55a1n1 requested a review from dangush October 8, 2024 20:56
davekaj
davekaj approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@davekaj davekaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reviewed it and tested it, it works

@davekaj davekaj merged commit b3fe3bf into main Oct 10, 2024
8 checks passed
@davekaj davekaj deleted the hu55a1n1/242-easy-fmspc branch October 10, 2024 13:57
hu55a1n1 added a commit that referenced this pull request Oct 21, 2024
@hu55a1n1
feat(cli): print-fmspc command (#247)
7f2778f 
Co-authored-by: Dave Kaj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davekaj davekaj davekaj approved these changes

@dangush dangush Awaiting requested review from dangush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to determine a machine's fmspc
2 participants
@hu55a1n1 @davekaj