test(channel upgradability): add integration test that relays packets…

… during flushing (#3786)

* test: add integration test that flushes packets during channel upgrade

* wip: add counterparty upgrade sequence to chan upgrade open

* update integration test

* cargo fmt

* Fix UpgradeInit parsing and Registering ICA account following simd changes

* handle new fields in messages: order in msg register interchain account and counterparty upgrade sequence in msg channel upgrade open

* fix warnings

* Update Nix flake

* address review comments

* cargo fmt

* some clippy warnings

* fix assert_eq!

* fix test

* cargo fmt

* chore: rename order to ordering in msg register interchain account

* Use ibc-go v8.1.0-rc.0 for channel upgrade tests

* Add and use legacy 'MsgRegisterInterchainAccount'

* Use different signer to initialise channel upgrade for 'test_channel_upgrade_handshake' test

* add test where ICA channel is upgraded to unordered

* cargo fmt + add debug log

* increase packet timeout

* Add case where Channel upgrade Try event is received by source chain while dst chain is open not upgrading

* Use user2 to signe channel upgrade init proposal in ICA unordered test

---------

Co-authored-by: Luca Joss <[email protected]>

.github/workflows/integration.yaml

@@ -173,7 +173,7 @@ jobs:
       fail-fast: false
       matrix:
         chain:
-          - package: ibc-go-v8-channel-upgrade-simapp
+          - package: ibc-go-v8-simapp
             command: simd
             account_prefix: cosmos
     steps:

crates/relayer-types/src/applications/ics27_ica/error.rs

@@ -1,3 +1,4 @@
+use crate::core::ics04_channel::error as channel_error;
 use crate::core::ics24_host::error::ValidationError;
 use crate::signer::SignerError;
 
@@ -6,6 +7,10 @@ use flex_error::define_error;
 define_error! {
     #[derive(Debug, PartialEq, Eq)]
     Error {
+        Ics04Channel
+            [ channel_error::Error ]
+            | _ | { "ics04 channel error" },
+
         Owner
         [ SignerError ]
             | _ | { "failed to parse owner" },