Skip to content

imp(ibc-testkit): revamp mock testing framework #101

imp(ibc-testkit): revamp mock testing framework

imp(ibc-testkit): revamp mock testing framework #101

Triggered via pull request February 29, 2024 18:12
Status Success
Total duration 14s
Artifacts

code-quality.yml

on: pull_request
code-quality
5s
code-quality
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
mismatched types: ibc-testkit/src/testapp/ibc/core/types.rs#L511
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/types.rs:511:54 | 511 | let client_state_path = ClientStatePath::new(client_id); | -------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:137:12 | 137 | pub fn new(client_id: ClientId) -> ClientStatePath { | ^^^ help: consider using clone here | 511 | let client_state_path = ClientStatePath::new(client_id.clone()); | ++++++++
mismatched types: ibc-testkit/src/testapp/ibc/core/types.rs#L511
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/types.rs:511:54 | 511 | let client_state_path = ClientStatePath::new(client_id); | -------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:137:12 | 137 | pub fn new(client_id: ClientId) -> ClientStatePath { | ^^^ help: consider using clone here | 511 | let client_state_path = ClientStatePath::new(client_id.clone()); | ++++++++
mismatched types: ibc-testkit/src/testapp/ibc/core/core_ctx.rs#L444
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/core_ctx.rs:444:64 | 444 | let client_connection_path = ClientConnectionPath::new(client_id); | ------------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:352:12 | 352 | pub fn new(client_id: ClientId) -> ClientConnectionPath { | ^^^ help: consider using clone here | 444 | let client_connection_path = ClientConnectionPath::new(client_id.clone()); | ++++++++
mismatched types: ibc-testkit/src/testapp/ibc/core/core_ctx.rs#L444
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/core_ctx.rs:444:64 | 444 | let client_connection_path = ClientConnectionPath::new(client_id); | ------------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:352:12 | 352 | pub fn new(client_id: ClientId) -> ClientConnectionPath { | ^^^ help: consider using clone here | 444 | let client_connection_path = ClientConnectionPath::new(client_id.clone()); | ++++++++
mismatched types: ibc-testkit/src/testapp/ibc/core/types.rs#L511
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/types.rs:511:54 | 511 | let client_state_path = ClientStatePath::new(client_id); | -------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:137:12 | 137 | pub fn new(client_id: ClientId) -> ClientStatePath { | ^^^ help: consider using clone here | 511 | let client_state_path = ClientStatePath::new(client_id.clone()); | ++++++++
mismatched types: ibc-testkit/src/testapp/ibc/core/core_ctx.rs#L444
error[E0308]: mismatched types --> ibc-testkit/src/testapp/ibc/core/core_ctx.rs:444:64 | 444 | let client_connection_path = ClientConnectionPath::new(client_id); | ------------------------- ^^^^^^^^^ expected `ClientId`, found `&ClientId` | | | arguments to this function are incorrect | note: associated function defined here --> /home/runner/work/ibc-rs/ibc-rs/ibc-core/ics24-host/types/src/path.rs:352:12 | 352 | pub fn new(client_id: ClientId) -> ClientConnectionPath { | ^^^ help: consider using clone here | 444 | let client_connection_path = ClientConnectionPath::new(client_id.clone()); | ++++++++
code-quality
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
code-quality
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/