Skip to content

Commit

Permalink
fix: cargo test --no-default-features
Browse files Browse the repository at this point in the history
  • Loading branch information
Farhad-Shabani committed Nov 27, 2023
1 parent fc25b94 commit 823274a
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix Cargo test failure with `--no-default-features` flag.
([\#770](https://github.com/cosmos/ibc-rs/issues/770))
2 changes: 1 addition & 1 deletion .changelog/unreleased/bug-fixes/987-serde-json-feature.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Fix dependency resolution by removing the `dep:` syntax in `serde` feature of
`ibc-app-transfer` crate.
([#987](https://github.com/cosmos/ibc-rs/issues/987))
([\#987](https://github.com/cosmos/ibc-rs/issues/987))
4 changes: 4 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,7 @@ jobs:
with:
command: test
args: --all-features --no-fail-fast --workspace -- --nocapture
- uses: actions-rs/cargo@v1
with:
command: test
args: --no-default-features --no-fail-fast --no-run
2 changes: 1 addition & 1 deletion ibc-testkit/src/fixtures/clients/tendermint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ pub fn dummy_ics07_header() -> Header {
}
}

#[cfg(test)]
#[cfg(all(test, feature = "serde"))]
mod tests {

use ibc::primitives::proto::Any;
Expand Down
4 changes: 2 additions & 2 deletions ibc-testkit/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![cfg_attr(not(test), deny(clippy::unwrap_used))]
#![no_std]
#![forbid(unsafe_code)]
#![cfg_attr(not(test), deny(clippy::unwrap_used))]
#![deny(
warnings,
trivial_casts,
Expand All @@ -8,7 +9,6 @@
unused_qualifications,
rust_2018_idioms
)]
#![forbid(unsafe_code)]

extern crate alloc;

Expand Down
1 change: 0 additions & 1 deletion ibc-testkit/src/relayer/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ mod tests {
use ibc::core::client::types::Height;
use ibc::core::handler::types::msgs::MsgEnvelope;
use ibc::core::host::types::identifiers::ChainId;
use test_log::test;
use tracing::debug;

use super::RelayerContext;
Expand Down
1 change: 0 additions & 1 deletion ibc-testkit/src/testapp/ibc/core/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,6 @@ mod tests {
use ibc::core::primitives::Signer;
use ibc::core::router::module::Module;
use ibc::core::router::types::module::{ModuleExtras, ModuleId};
use test_log::test;

use super::*;
use crate::fixtures::core::channel::PacketConfig;
Expand Down
1 change: 1 addition & 0 deletions ibc-testkit/tests/applications/mod.rs
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#[cfg(feature = "serde")]
pub mod transfer;
2 changes: 2 additions & 0 deletions ibc-testkit/tests/core/ics02_client/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#[cfg(feature = "serde")]
pub mod create_client;
pub mod update_client;
#[cfg(feature = "serde")]
pub mod upgrade_client;
1 change: 1 addition & 0 deletions ibc-testkit/tests/core/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pub mod ics02_client;
pub mod ics03_connection;
pub mod ics04_channel;
#[cfg(feature = "serde")]
pub mod router;

0 comments on commit 823274a

Please sign in to comment.