Skip to content

Commit

Permalink
fix: propagate base64 from workspace (#1085)
Browse files Browse the repository at this point in the history
  • Loading branch information
Farhad-Shabani authored Feb 9, 2024
1 parent 7ff2796 commit 850957c
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 21 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- [ibc] Resolve potential `base64` dependency resolution issue by bringing it to
the workspace `Cargo.toml`
([\#1084](https://github.com/cosmos/ibc-rs/issues/1084))
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ authors = ["Informal Systems <[email protected]>"]

[workspace.dependencies]
# external dependencies
base64 = { version = "0.21", default-features = false }
borsh = { version = "0.10", default-features = false }
displaydoc = { version = "0.2", default-features = false }
derive_more = { version = "0.99.17", default-features = false, features = ["from", "into", "display", "try_into"] }
Expand Down
34 changes: 17 additions & 17 deletions ci/cw-check/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ci/cw-check/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ crate-type = ["cdylib", "rlib"]
[dependencies]
ibc-apps = { path = "../../ibc-apps", default_features = false, features = ["serde", "parity-scale-codec"] }
ibc-core = { path = "../../ibc-core", features = ["serde", "parity-scale-codec", "schema"] }
cosmwasm-std = { version = "^1.5.0", default-features = false }
cosmwasm-schema = { version = "^1.5.0", default-features = false }
cosmwasm-std = { version = "^1.5.3", default-features = false }
cosmwasm-schema = { version = "^1.5.3", default-features = false }
serde_json = { package = "serde-json-wasm", version = "^1.0.1", default-features = false }
thiserror = { version = "^1.0", default-features = false }

Expand Down
2 changes: 1 addition & 1 deletion ibc-apps/ics721-nft-transfer/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ all-features = true
[dependencies]
# external dependencies
borsh = { workspace = true, optional = true }
base64 = { version = "0.21.6", default-features = false }
base64 = { workspace = true }
derive_more = { workspace = true }
displaydoc = { workspace = true }
http = "1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion ibc-clients/ics08-wasm/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ description = """

[dependencies]
# external dependencies
base64 = { version = "0.21", default-features = false, features = ["alloc"] }
base64 = { workspace = true , features = ["alloc"] }
displaydoc = { workspace = true }
serde = { workspace = true , optional = true }
cosmwasm-schema = { version = "1.4.1", default-features = false, optional = true }
Expand Down

0 comments on commit 850957c

Please sign in to comment.