Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add makefile #1071

Merged
merged 4 commits into from
Feb 21, 2024
Merged

misc: add makefile #1071

merged 4 commits into from
Feb 21, 2024

Conversation

Farhad-Shabani
Copy link
Member

Description

This streamlines the workflow for developers who wish to examine changes, manage dependencies, and execute multiple commands simultaneously during the development process.


PR author checklist:

  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani requested a review from rnbguy February 1, 2024 18:51
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d2805c) 67.07% compared to head (ed05ba6) 66.58%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
- Coverage   67.07%   66.58%   -0.50%     
==========================================
  Files         204      204              
  Lines       20543    20519      -24     
==========================================
- Hits        13780    13663     -117     
- Misses       6763     6856      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Farhad-Shabani

Added two comments.

.github/workflows/no-std.yaml Show resolved Hide resolved
makefile Show resolved Hide resolved
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! ✨

@rnbguy rnbguy merged commit 49e66de into main Feb 21, 2024
15 checks passed
@rnbguy rnbguy deleted the farhad/add-makefile branch February 21, 2024 10:23
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* chore: add makefile

* nit: types + use make check-features

* nit

* imp: add install-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants