-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use header height for Tendermint consensus state storage #1081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 66.63% 66.81% +0.17%
==========================================
Files 204 204
Lines 20435 20437 +2
==========================================
+ Hits 13617 13654 +37
+ Misses 6818 6783 -35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* fix: use header height for Tendermint consensus state storage * fix: make clippy 0.1.76 happy * test: add test_update_client_with_prev_header * nit: remove redundant clones * fix: remove stale header test
Closes: #1080
Along with this PR
breaking-changes
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.