Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use header height for Tendermint consensus state storage #1081

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Feb 8, 2024

Closes: #1080

Along with this PR

  • Removed the check and test for stale mock headers as it was not sufficiently general and did not provide meaningful validation.
  • Nit: placing unclog of issue 835 under the breaking-changes

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4428fa9) 66.63% compared to head (ebcc3e8) 66.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   66.63%   66.81%   +0.17%     
==========================================
  Files         204      204              
  Lines       20435    20437       +2     
==========================================
+ Hits        13617    13654      +37     
+ Misses       6818     6783      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks good to me

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Farhad-Shabani Farhad-Shabani merged commit c8dcb04 into main Feb 9, 2024
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/fix-tm-cons-state-storage branch February 9, 2024 16:55
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* fix: use header height for Tendermint consensus state storage

* fix: make clippy 0.1.76 happy

* test: add test_update_client_with_prev_header

* nit: remove redundant clones

* fix: remove stale header test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICS07] Incorrect ConsensusState storage for headers with heights lower than ClientState height
3 participants