Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade serde_json to version "1.0.1" #1083

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Farhad-Shabani
Copy link
Member

Description

The serde-json-wasm stack overflow during recursive JSON parsing. Fixed in version 1.0.1.


PR author checklist:

  • Added changelog entry, using unclog.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8dcb04) 66.81% compared to head (decc013) 66.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files         204      204           
  Lines       20437    20437           
=======================================
  Hits        13654    13654           
  Misses       6783     6783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit cf82f2a into main Feb 9, 2024
16 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/bump-serde-json branch February 9, 2024 19:29
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 9, 2024
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* deps: bump serde_json version

* chore: add unclog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants