Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement convenient path methods + add iteration key #1091

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1090
Closes: #1089


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (3b260e2) 66.81% compared to head (a5f0536) 66.58%.

Files Patch % Lines
ibc-core/ics24-host/types/src/path.rs 26.80% 71 Missing ⚠️
ibc-query/src/core/connection/query.rs 0.00% 2 Missing ⚠️
ibc-clients/ics07-tendermint/src/client_state.rs 75.00% 1 Missing ⚠️
ibc-query/src/core/channel/query.rs 0.00% 1 Missing ⚠️
ibc-query/src/core/client/query.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   66.81%   66.58%   -0.23%     
==========================================
  Files         204      204              
  Lines       20437    20519      +82     
==========================================
+ Hits        13654    13663       +9     
- Misses       6783     6856      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani changed the title feat: implement convenient path methods + add iterateConsensusState key feat: implement convenient path methods + add iteration key Feb 15, 2024
ibc-core/ics24-host/types/src/path.rs Outdated Show resolved Hide resolved
ibc-core/ics24-host/types/src/path.rs Outdated Show resolved Hide resolved
@Farhad-Shabani Farhad-Shabani merged commit b959279 into main Feb 15, 2024
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/path-improvements branch February 15, 2024 15:42
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* feat: implement convenient path methods + add iterateConsensusState key

* imp: just keeping iteration key func

* nitpicking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants