Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibc-core): pack host consensus state into wasm consensus state for wasm clients #1252

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Jun 7, 2024

Closes: #1237

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (478b4c6) to head (a2a2b7d).

Files Patch % Lines
ibc-core/ics03-connection/src/handler/mod.rs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   67.26%   67.27%   +0.01%     
==========================================
  Files         235      235              
  Lines       23516    23538      +22     
==========================================
+ Hits        15817    15836      +19     
- Misses       7699     7702       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy marked this pull request as ready for review June 12, 2024 12:36
@rnbguy rnbguy requested a review from seanchen1991 June 12, 2024 12:36
@rnbguy rnbguy force-pushed the rano/fix/wasm-consensus-state branch from c73d9a7 to a2a2b7d Compare June 12, 2024 12:41
@rnbguy rnbguy added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit ac579fa Jun 12, 2024
19 checks passed
@rnbguy rnbguy deleted the rano/fix/wasm-consensus-state branch June 12, 2024 18:18
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…r wasm clients (#1252)

* add custom consensus state packing

* change feature flag

* change doc comments

* add pack_host_consensus_state fn

* fix imports

* update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support ICS008 wrapper type for host client and consensus state
2 participants