Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CosmWasm dependencies to new cosmwasm workspace #1302

Merged
merged 23 commits into from
Aug 7, 2024

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Aug 5, 2024

Closes: #1295

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.99%. Comparing base (c21c676) to head (90dbb66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
- Coverage   67.55%   66.99%   -0.56%     
==========================================
  Files         236      226      -10     
  Lines       23905    23267     -638     
==========================================
- Hits        16148    15588     -560     
+ Misses       7757     7679      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani mentioned this pull request Aug 6, 2024
15 tasks
@Farhad-Shabani Farhad-Shabani added this to the 0.54.0 milestone Aug 6, 2024
@seanchen1991 seanchen1991 marked this pull request as ready for review August 6, 2024 20:13
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sean.
Just a heads-up: I have refactored the GitHub workflows and the Makefile so that CI jobs include the cosmwasm workspace as well.

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 229add4 Aug 7, 2024
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the seanchen1991/split-cosmwasm-workspace-899 branch August 7, 2024 00:07
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Move cw dependencies to cosmwasm/ibc-clients directory

* Move cosmwasm tests to `cosmwasm` workspace

* Fix some formatting nits

* Format cargo.toml files

* Add needed workspace dependencies

* Add derive_more dep back to root Cargo.toml

* Format cargo.toml files

* Updates to Cargo.toml files

* Format cargo.toml files

* Add needed test imports

* Resolve testing dependencies

* Fix Makefile `build-tendermint-cw` rule

* fix: remove redundant deps

* fix: makefile

* fix: update workflows

* fix: refactor workflows to include cosmwasm lint checks

* fix: include cosmwasm check-docs in CI

* fix: include cosmwasm tests in CI + streamline jobs

* fix: update READMEs

* nitpicking

* chore: add changelog

* fix: taplo

* nit: readme paths

---------

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV check fails as derive_more-impl v1.0.0-beta.6 requires Rust 1.75.0
2 participants