Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove faulty receipt check during recv_packet_validate #1337

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Sep 12, 2024

Closes: #1336


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani added this to the 0.55.0 milestone Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.46%. Comparing base (4e6c12e) to head (6a66300).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ibc-core/ics04-channel/types/src/packet.rs 42.85% 4 Missing ⚠️
ibc-query/src/core/channel/query.rs 0.00% 1 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   66.48%   66.46%   -0.03%     
==========================================
  Files         227      227              
  Lines       23114    23098      -16     
==========================================
- Hits        15368    15352      -16     
  Misses       7746     7746              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ibc-query/src/core/channel/query.rs Outdated Show resolved Hide resolved
ibc-core/ics04-channel/src/handler/recv_packet.rs Outdated Show resolved Hide resolved
@seanchen1991 seanchen1991 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 25f730d Sep 12, 2024
14 checks passed
@seanchen1991 seanchen1991 deleted the farhad/explicit-receipt-none branch September 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty receipt check during receive packet validation
2 participants