feat: replace store_update_{time,height} by metadata update #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observe that update time and height are always read and manipulated
together. Replace pairs of methods for reading, updating and deleting
time and height with a single combined method for each operation.
Specifically, replace:
a) client_update_{time,height} by client_update_meta,
b) store_update_{time,height} by store_update_meta and
c) delete_update_{time,height} by delete_update_meta.
This allows better optimised implementations which, for example, keep
both pieces of information in a single map and perform a single lookup
to read or update them.
Furthermore, since the host timestamp and height come from the
implementation, remove those arguments from the store_update_meta
method with the implementation fetching the information by itself.
Closes: #973
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.