Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo test with no-default-features flag #989

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #770


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc25b94) 70.30% compared to head (823274a) 70.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   70.30%   70.77%   +0.46%     
==========================================
  Files         178      178              
  Lines       17692    17949     +257     
==========================================
+ Hits        12439    12704     +265     
+ Misses       5253     5245       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review November 27, 2023 03:51
@Farhad-Shabani Farhad-Shabani mentioned this pull request Nov 27, 2023
@Farhad-Shabani Farhad-Shabani merged commit 841ceac into main Nov 27, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/test-no-def-feat branch November 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test fails with no-default-features
2 participants