Optimize computeRoutePrefix (prometheus#584)

* Optimize computeRoutePrefix Previously, computeRoutePrefix was adding a '/' to the start of the prefix and then removing it from the end, regardless of whether it was there or not. This resulted in unnecessary string operations. The updated function only adds or removes the '/' when necessary, improving efficiency. Additionally, the function now uses strings.HasPrefix and strings.HasSuffix for clearer intent and readability. Signed-off-by: donuts-are-good <[email protected]> --------- Signed-off-by: donuts-are-good <[email protected]>
infrawatch · Oct 21, 2023 · ec7afda · ec7afda
1 parent 53697b6
commit ec7afda
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/main.go b/main.go
@@ -251,13 +251,16 @@ func computeRoutePrefix(prefix string, externalURL *url.URL) string {
 	}
 
 	if prefix == "/" {
-		prefix = ""
+		return ""
 	}
 
-	if prefix != "" {
-		prefix = "/" + strings.Trim(prefix, "/")
+	// Ensure prefix starts with "/".
+	if !strings.HasPrefix(prefix, "/") {
+		prefix = "/" + prefix
 	}
 
+	prefix = strings.TrimSuffix(prefix, "/")
+
 	return prefix
 }