Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped elements v3 #2168

Merged
merged 38 commits into from
Feb 7, 2024
Merged

Scoped elements v3 #2168

merged 38 commits into from
Feb 7, 2024

Conversation

okadurin
Copy link
Collaborator

@okadurin okadurin commented Jan 17, 2024

  • @open-wc/scoped-elements is updated to v3
  • The import of ScopedElementsMixin is changed from @open-wc/scoped-elements to @open-wc/scoped-elements/lit-element.js as the API changed
  • To allow creating elements in global scope and keep backward compatibility, packages/ui/components/core/src/ScopedElementsMixin.js is created. It extends/overrides original @open-wc/scoped-elements/lit-element.js
  • Polyfill is enabled for all tests by default. Done by updating web-test-runner.config.mjs
  • getScopedTagName is removed according to the migration doc
  • ScopedElementsHost is moved to our source code since the class is not exposed by @open-wc/scoped-elements/lit-element.js anymore
  • Some tests are skipped as they don't work well with the polyfill even on master. The corresponding user stories are created to fix that

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: 38f5b46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@okadurin okadurin marked this pull request as draft January 17, 2024 17:16
@okadurin okadurin self-assigned this Jan 17, 2024
@okadurin okadurin changed the base branch from lit3-alpha to master January 17, 2024 17:32
@okadurin okadurin changed the base branch from master to lit3-alpha January 17, 2024 17:33
@okadurin okadurin marked this pull request as ready for review January 24, 2024 14:39
@tlouisse tlouisse merged commit 6acd7f2 into lit3-alpha Feb 7, 2024
5 checks passed
@tlouisse tlouisse deleted the scoped-elements-v3 branch February 7, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants