Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drink 0.8.7 #112

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Drink 0.8.7 #112

merged 5 commits into from
Mar 6, 2024

Conversation

pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Mar 6, 2024

Fixes #107

  1. Revert Update cargo-contract crate versions #91 (go back to [email protected] and contract_*@3.2.0)
  2. Port Accessing emitted events #92 feature over these reversion
  3. Bump rust to 1.74

If common-amm and ink-wrapper works well with 0.8.7, then 0.8.6 and 0.8.5 will be yanked

@pmikolajczyk41 pmikolajczyk41 requested a review from deuszx March 6, 2024 11:18
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

As for "git hygienic" - can you try with get revert first next time? I understand that it might require more work "afterwards" (ie in the "fix the revert commit" commit) but it's cleaner what the flow/reasoning was. I think.

@pmikolajczyk41 pmikolajczyk41 merged commit 6f71dba into release-0.8.7 Mar 6, 2024
2 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the drink-8.7 branch March 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants