Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiR Connector: Allow connector to start disconnected and publish api_connected value #36

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

b-Tomas
Copy link
Member

@b-Tomas b-Tomas commented Feb 3, 2025

🗒️ Description

  • Retry initialization of missions group in the background in case the API is not available at startup
  • Lazy initialize the API web session (it is rarely used, only for waypoint navigation through deprecated methods)
  • Publish api_connected, used for indicating the connection health in InOrbit

📺 Demo

The demo shows the connector starting and working while the connection to the robot is blocked and unblocked:

2025-02-05-13.41.07.579176310.mp4

…e requests, impeding the connector from starting if a connection to the robot is not established
@b-Tomas b-Tomas self-assigned this Feb 3, 2025
@b-Tomas b-Tomas marked this pull request as ready for review February 4, 2025 15:11
@b-Tomas b-Tomas requested a review from miguelgarcia February 4, 2025 16:24
@b-Tomas b-Tomas requested a review from miguelgarcia February 5, 2025 13:46
Copy link
Member

@miguelgarcia miguelgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@b-Tomas b-Tomas merged commit 01db750 into main Feb 5, 2025
12 checks passed
@b-Tomas b-Tomas deleted the mir_api_connected branch February 5, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants