Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests #713

Open
janivo opened this issue Aug 25, 2022 · 0 comments
Open

Add snapshot tests #713

janivo opened this issue Aug 25, 2022 · 0 comments
Assignees
Labels
feature This issue introduces a new feature
Milestone

Comments

@janivo
Copy link
Collaborator

janivo commented Aug 25, 2022

Feature Request

To prevent regression e.g. when updating the MDC libraries, we should have a way to see if anything (e.g. the structure of a component) changed unintentionally.

Description of the proposed solution

Add snapshots tests.

Description of the considered alternatives

An alternative is visual regression testing (a.k.a. screenshot tests). As #683 showed, these seem to be really flaky in our current setup and therefore are not suited for us at the moment.

Additional context

Snapshot testing is already partially implemented by #698 but there is still a problem with components that generate a unique ID to function properly. These ids changes with every render and therefore differ every test run.

@janivo janivo added feature This issue introduces a new feature discussion This issue needs to be discussed further new This issue has been recently added and has no estimation labels Aug 25, 2022
@janivo janivo self-assigned this Aug 25, 2022
@janivo janivo added this to the Housekeeping milestone Aug 25, 2022
@janivo janivo removed discussion This issue needs to be discussed further new This issue has been recently added and has no estimation labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue introduces a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant