Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add visual regression tests #683

Closed
wants to merge 15 commits into from

Conversation

JCofman
Copy link
Contributor

@JCofman JCofman commented Aug 3, 2022

Closes #213

Proposed Changes

Adds Storybook test-runner for running visual regression tests for each story.

Things to check

  • Does the change need to be documented?
  • Does any existing example code needs to be updated?
  • Is the change properly tested?
  • Is it helpful to provide another example to demonstrate the new feature?
  • Are there other code lines that need to be modified?

@JCofman JCofman changed the title DRAFT: chore: add visual regression tests chore: add visual regression tests Aug 4, 2022
@janivo janivo force-pushed the master branch 2 times, most recently from ba79411 to 295e438 Compare August 4, 2022 13:30
janivo
janivo previously approved these changes Aug 10, 2022
@janivo janivo marked this pull request as draft August 18, 2022 07:30
@janivo janivo mentioned this pull request Aug 25, 2022
@janivo
Copy link
Collaborator

janivo commented Sep 13, 2022

Closing as they are really flaky and we would rather use snapshot test for now (see #713)

Nevertheless, big thanks @JCofman for your contribution! It will be relevant in the future for sure

@janivo janivo closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Regression Tests (Screenshot Tests)
2 participants