-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(landingpage): add patterns preview-code-box #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasHeimGalindo
changed the title
feat: add initial patterns page under library section
feat(landingpage): add patterns preview-code-box
Oct 23, 2023
TobiasHeimGalindo
temporarily deployed
to
github-pages
October 23, 2023 10:28 — with
GitHub Actions
Inactive
shiki is the same syntax highlighter code-hike uses in our guides.
janivo
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! It's really fun clicking around because of those little gimmicks you've implemented 💯
packages/landingpage/pages/[lang]/library/patterns/preview-box.tsx
Outdated
Show resolved
Hide resolved
packages/landingpage/pages/[lang]/library/patterns/preview-box.tsx
Outdated
Show resolved
Hide resolved
packages/landingpage/pages/[lang]/library/patterns/preview-box.tsx
Outdated
Show resolved
Hide resolved
janivo
approved these changes
Nov 16, 2023
iandi09
pushed a commit
that referenced
this pull request
Dec 22, 2023
Co-authored-by: Jan-Niklas Voß <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076
Notes: once deployed, the patterns page will be filtered out of our routes(non-existant in our navbar and footer) and if searching the url /library/patterns it will show our Custom404 screen to redirect to our Home Page
Preview:
2023-11-15.12-08-32.mp4