Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct exporter version #65

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Dmitry-Eremeev
Copy link

#64

@Knalltuete5000
Copy link
Collaborator

From my testing with your patch there no version displayed either by running

./prometheus-libvirt-exporter --version
libvirt_exporter, version  (branch: , revision: b2cead90be5d2455a2a5a75c1aa719f241b82993)
  build user:       
  build date:       
  go version:       go1.23.5
  platform:         linux/amd64
  tags:             unknown

or when starting the exporter

level=INFO source=main.go:47 msg="Starting libvirt_exporter" version="(version=, branch=, revision=b2cead90be5d2455a2a5a75c1aa719f241b82993-modified)"

Have you received other results?

@Dmitry-Eremeev
Copy link
Author

Hi,

you don't see version because there is no version in your binary.
Please do git commit and add git tag.
Build your code by goreleaser.
Or you can take release code and build it:
https://github.com/inovex/prometheus-libvirt-exporter/tree/v1.6.0

@Knalltuete5000
Copy link
Collaborator

I have tested the current main branch and your changes with the goreleaser and can confirm the change works as expected. Thanks for the contribution and the fix

@Knalltuete5000 Knalltuete5000 linked an issue Feb 18, 2025 that may be closed by this pull request
@frittentheke frittentheke merged commit 089952e into inovex:master Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter does not show its version
3 participants