Skip to content

Commit

Permalink
fix: Fixed misspelled words
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanbogale committed Dec 10, 2024
1 parent 020b5b2 commit d86e6fd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions guides_and_processes/engineering_meetings.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

## Daily Meetings

### Team Standups
### Team Standup
- **Attendees:** Individual Engineering Teams
- **Purpose:**
- Quick update on daily progress
Expand All @@ -44,7 +44,7 @@
- **Attendees:** Engineering Managers, Product Manager
- **Purpose:**
- Prioritize and refine the backlog
- Ensure alignment between engineering and product roadmaps
- Ensure alignment between engineering and product roadmap

Check warning on line 47 in guides_and_processes/engineering_meetings.md

View workflow job for this annotation

GitHub Actions / Check spelling

Unknown word (roadmap)

### Engineering Management Meeting
- **Attendees:** Engineering Managers
Expand Down
12 changes: 6 additions & 6 deletions guides_and_processes/process_improvements.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
- Keep the PR updated with your latest changes

3. **Monitor Tags**
- Watch for `PR Walkthrough` tags on your PR
- Watch for `PR Walk-through` tags on your PR
- These tags indicate a need for additional review steps

### What to Expect
Expand All @@ -32,18 +32,18 @@
- Daily review of draft PRs
- Focus on requirement alignment
- Direct communication with developers via Slack if issues are found
- May tag PRs requiring walkthroughs
- May tag PRs requiring walk-throughs

#### Developer Role
- Focus reviews on "Ready" PRs, not drafts
- If PR is tagged for walkthrough:
- If PR is tagged for walk-through:
- Schedule 1:1 with a peer when PR is ready
- Conduct live code walkthrough
- Conduct live code walk-through

#### Review Guidelines
- Small PRs (1 day or less of work) can skip draft stage
- Other team members should focus on reviewing PRs marked as ready
- Tagged PRs require peer walkthrough before final review
- Tagged PRs require peer walk-through before final review

### Expected Outcomes

Expand Down Expand Up @@ -104,4 +104,4 @@ PRs that can be completed in one day or less may proceed directly to review with
- More efficient use of engineering management time by:
- Combining grooming and prioritization
- Improving epic/issue quality before team presentation
- Streamlining communication processes
- Streamlining communication processes

0 comments on commit d86e6fd

Please sign in to comment.