-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust/cardano-blockchain-types): cardano-blockchain-types
base change
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
…ake2bHash Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Stanislav Tkach <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
stevenj
requested changes
Jan 3, 2025
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
stevenj
requested changes
Jan 3, 2025
stevenj
requested changes
Jan 3, 2025
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
8 tasks
* fix(cardano-blockchain-types): key registration Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): registration witness Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): voting pk Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): validation test Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): format Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): move cip36 to be under metadata Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): use decode_helper from cbork-utils Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): visibility, cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): handle unset data Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 err report Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): update cbor-utils tag Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 now contain validation Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 validation implement getter Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): remove validation from cip36 struct Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): improve verifying key error log Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
8 tasks
Merged
8 tasks
…P36 (#142) * fix(cardano-blockchain-types): key registration Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): registration witness Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): voting pk Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): validation test Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): format Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): move cip36 to be under metadata Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): use decode_helper from cbork-utils Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): visibility, cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): handle unset data Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 err report Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): update cbor-utils tag Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 now contain validation Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 validation implement getter Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): remove validation from cip36 struct Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): improve verifying key error log Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): implement new error report Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): function name Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): print report Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): version for catalyst-types Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): move found key check to its own function Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): pass cip36 ProblemReport as context Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): format Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): key reg redundant code and missing key checking Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): remove cip36validation struct Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): add more fileds, fix return error Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): add cip36_from_block function Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): remove serde_json Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): format Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): impl display for cip36 error Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): cip36 key reg function Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): problem report conversion err Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): impl display for cip36 Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): err report getter Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): update catalyst-types tag Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): return type for cip36 constructor Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): logic Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): format Signed-off-by: bkioshn <[email protected]> * fix(cardano-blockchain-types): rename ctx Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>
stevenj
approved these changes
Jan 9, 2025
✅ Test Report | |
✅ Test Report | |
apskhem
approved these changes
Jan 9, 2025
8 tasks
8 tasks
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All changes besides from #107 will be merged into this branch
Change include
CIP36
txn_index