-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust/c509-certificate): Update to version 11 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkioshn
changed the title
feat(rust/c509-certificate): **DO NOT MERGE YET** Update to version 11
feat(rust/c509-certificate): DO NOT MERGE YET - Update to version 11
Sep 12, 2024
stevenj
previously approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#26) * fix: naming + add neccesary function * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup --------- Co-authored-by: Steven Johnson <[email protected]>
* fix: naming + add neccesary function * fix(rust/c509-certificate): add encode + decode helper functions * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): remove unnecessary allow(dead_code) * fix(rust/c509-certificate): generic encode and decode functions
* fix: naming + add neccesary function * fix(rust/c509-certificate): add encode + decode helper functions * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): remove unnecessary allow(dead_code) * fix(rust/c509-certificate): fix encode decode Name * chore(rust/c509-certificate): fix comment * fix(rust/c509-certificate): add + rewrite test cases * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): remove earthly no-cache * fix(rust/c509-certificate): add more test comments * fix(rust/c509-certificate): clippy lints --------- Co-authored-by: Steven Johnson <[email protected]> Co-authored-by: Steven Johnson <[email protected]>
…do to the chain follower
…ed src == the expected src
…d in the cache check target
Signed-off-by: bkioshn <[email protected]>
* fix(rust/c509-certificate): docs Signed-off-by: bkioshn <[email protected]> * fix(rust/c509-certificate): spelling Signed-off-by: bkioshn <[email protected]> * fix(rust/c509-certificate): anyhow format Signed-off-by: bkioshn <[email protected]> * docs(rust/c509-certificate): make doc clearer Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
bkioshn
changed the title
feat(rust/c509-certificate): DO NOT MERGE YET - Update to version 11
feat(rust/c509-certificate): Update to version 11
Oct 6, 2024
stevenj
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
c509-certificate
crate follows draft 9, update it to draft 11.Version 11: https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/11/
Version 9: https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/09/
Related Issue(s)
Closes #19
Blocks #49
Description of Changes
Differences between 9 and 11 for the current implementation
Breaking Changes
Please confirm the following checks