Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust/cardano-chain-follower): Update RBAC 509 API #50

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix(rust/cardano-chain-follower): Update RBAC 509 API #50

merged 3 commits into from
Oct 7, 2024

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Oct 6, 2024 •
edited
Loading

Description

Add types and utility functions to the public API for RBAC 509 registrations

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added the bug Something isn't working label Oct 6, 2024
@saibatizoku saibatizoku requested review from stevenj and bkioshn October 6, 2024 23:30
@saibatizoku saibatizoku self-assigned this Oct 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 202/202}$ | ${\color{red}Fail: 0/202}$ |

@saibatizoku saibatizoku added the review me PR is ready for review label Oct 6, 2024
@saibatizoku saibatizoku changed the base branch from main to fix/bump-ci-and-version-of-chain-follower October 7, 2024 01:39
@stevenj stevenj merged commit 9c878f0 into fix/bump-ci-and-version-of-chain-follower Oct 7, 2024
19 checks passed
@stevenj stevenj deleted the feat/update-cip509-api branch October 7, 2024 02:34
stevenj added a commit that referenced this pull request Oct 7, 2024
@stevenj @saibatizoku
fix(general): Bump Versions (#49)
1409266 
* fix(general): Bump Versions

* fix(rust/hermes-ipfs): update to work with latest rust-ipfs version

* fix(rust/cardano-chain-follower): bump c509-certificate version

* fix(rust/cardano-chain-follower): remove unused clone

* fix(rust/cardano-chain-follower): Update RBAC 509 API (#50)

* fix(rust/cardano-chain-follower): make KeyLocalRef fields public

* feat(rust/cardano-chain-follower): make extract_cip19_hash public

* fix(rust/cardano-chain-follower): code format

* fix(rust): Bump all rust crates, and fix chain-follower -> c509 usage

* fix(rust): sync standard config

---------

Co-authored-by: Joaquín Rosales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj Awaiting requested review from stevenj

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@saibatizoku saibatizoku

Labels
bug Something isn't working review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saibatizoku @stevenj