Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use unstable Docker image ID in test-client workflow instead… #2272

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix: use unstable Docker image ID in test-client workflow instead… #2272

merged 1 commit into from
Feb 4, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 4, 2025 •
edited
Loading

Content

This PR includes a fix for the test-client github workflow when triggered by the nightly dispatcher, by changing the default docker_image_id from latest to unstable.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 42s ⏱️ -1s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc8ead4. ± Comparison against base commit 37387c4.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 4, 2025 09:27 — with GitHub Actions Inactive
@dlachaume
fix: use unstable Docker image ID in test-client workflow instead…
fc8ead4 
… of `latest` when triggered by the nightly dispatcher
@dlachaume dlachaume force-pushed the dlachaume/use-unstable-docker-image-id-in-nightly-workflow branch from 40d67dd to fc8ead4 Compare February 4, 2025 09:29
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 4, 2025 09:44 — with GitHub Actions Inactive
@dlachaume dlachaume changed the title fix: use unstable Docker image ID in test-client workflow instead… Fix: use unstable Docker image ID in test-client workflow instead… Feb 4, 2025
sfauvel
sfauvel approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 8ddf19d into main Feb 4, 2025
43 of 45 checks passed
@dlachaume dlachaume deleted the dlachaume/use-unstable-docker-image-id-in-nightly-workflow branch February 4, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud