Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore release option for build in Makefile for aggregator … #2278

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Restore release option for build in Makefile for aggregator … #2278

merged 2 commits into from
Feb 5, 2025

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Feb 5, 2025 •
edited
Loading

Content

This PR restore the --release option in build target of Makefile in

  • mithril-aggregator
  • mithril-client-cli

It was deleted by mistake in #2260

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2260

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 29s ⏱️ -25s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit afe620f. ± Comparison against base commit 7cc55d9.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview February 5, 2025 10:54 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 5, 2025 10:54 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review February 5, 2025 10:58
@sfauvel
fix: restore release option for build in Makefile for aggregator …
2543869 
…and `client_cli`
@sfauvel
chore: upgrade crate versions
afe620f 
* mithril-aggregator from `0.6.27` to `0.6.28`
* mithril-client-cli from `0.10.10` to `0.10.11`
@sfauvel sfauvel force-pushed the sfa/2260/add_release_to_build_command_in_makefile branch from 1bee045 to afe620f Compare February 5, 2025 14:17
@sfauvel sfauvel temporarily deployed to testing-preview February 5, 2025 14:27 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 5, 2025 14:27 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 2c175d0 into main Feb 5, 2025
38 checks passed
@sfauvel sfauvel deleted the sfa/2260/add_release_to_build_command_in_makefile branch February 5, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume