-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refining tags in documentation #248
Conversation
Code Coverage Summary
Diff against main
Results for commit: efc85b4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 14 suites 1s ⏱️ Results for commit efc85b4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🚀 It looks good.
I don't like the use of \cr
on MD, but it's unavoidable as it will consider any additional paragraph as part of @details
(unless we want to keep more instances of @description
in addition the the remaining one)
I left a minor comment about markdown list consistency
Unit Test Performance DifferenceAdditional test case details
Results for commit 5e4ff52 ♻️ This comment has been updated with latest results. |
following discussion on insightsengineering/teal.slice#506 (comment)
I refined the rd documentation by removing the
@description
and@details
tags, And using an explicit@description
tag to prevent the second and subsequent paragraphs from being turned into the@details
. I followed the guide from https://r-pkgs.org/man.html#title-description-details.