52 standardise optional notation

[kartikeyakirar]

part of insightsengineering/nestdevs-tasks#52

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           61       0  100.00%
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   33, 36-42, 52-58, 61
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      184       1  99.46%   275
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
TOTAL                              850      95  88.82%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 4619bcf

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   14 suites   2s ⏱️
192 tests 190 ✅ 2 💤 0 ❌
263 runs  261 ✅ 2 💤 0 ❌

Results for commit 4619bcf.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_matches_labels_to_variables_by_names_of_values_argument
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_removes_labels_on_NA_character_
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_returns_only_names_attribute_and_ignores_all_the_rest
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_sets_variable_labels_when_passed_named_character_vector
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_sets_variable_labels_when_passed_partially_named_character_vector
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_sets_variable_labels_when_passed_partially_named_unordered_character_vector
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_sets_variable_labels_when_passed_unnamed_character_vector
formatters_var_labels	💀	$0.01$	$-0.01$	col_labels_throws_if_label_is_not_a_character
formatters_var_labels	💀	$0.01$	$-0.01$	col_labels_throws_if_label_is_not_a_character_of_length_1
formatters_var_labels	💀	$0.01$	$-0.01$	col_labels_value_accepts_character_vector
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_value_accepts_named_vector
formatters_var_labels	💀	$0.01$	$-0.01$	col_labels_value_must_be_same_length_as_x
formatters_var_labels	💀	$0.01$	$-0.01$	col_labels_value_names_must_be_same_as_variable_names
formatters_var_labels	💀	$0.00$	$-0.00$	col_labels_works_with_labels_having_additional_attributes_including_names_
formatters_var_labels	💀	$0.00$	$-0.00$	col_relabel_removes_labels_on_NA_character_

Results for commit 62aca9b

♻️ This comment has been updated with latest results.

[m7pr]

Hey, 3 changes and all 3 are improper. Left comments. Please take a look and improve the PR. Then re-request the review from me again.