Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation note about links on r-devel #356

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #335

The links are correctly resolved to the package and R CMD check doesn't complain (with 2024-12-07 r87428 ucrt)

See insightsengineering/teal#1420 (comment) for a longer explanation.

@llrs-roche llrs-roche changed the title 335 man links@main Fix documentation note about links on r-devel Dec 11, 2024
Copy link
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                   1       0  100.00%
R/deprecated.R                  14       0  100.00%
R/dummy_function.R               2       2  0.00%    14-15
R/formatters_var_labels.R       61       0  100.00%
R/join_key.R                    38       0  100.00%
R/join_keys-c.R                 12       0  100.00%
R/join_keys-extract.R          128       0  100.00%
R/join_keys-names.R             15       0  100.00%
R/join_keys-parents.R           30       0  100.00%
R/join_keys-print.R             45       0  100.00%
R/join_keys-utils.R             73       3  95.89%   35-38
R/join_keys.R                   21       0  100.00%
R/teal_data-class.R             37       3  91.89%   64, 111-112
R/teal_data-constructor.R       11       2  81.82%   31, 35
R/teal_data-extract.R            3       0  100.00%
R/teal_data-get_code.R          13       8  38.46%   114-120, 124
R/teal_data-names.R              8       1  87.50%   31
R/teal_data-show.R               4       4  0.00%    14-19
R/testhat-helpers.R             26       0  100.00%
R/topological_sort.R            32       0  100.00%
R/verify.R                      42      11  73.81%   67, 97-101, 104-108
TOTAL                          616      34  94.48%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ea3b320

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 151 ✅ 12 💤 0 ❌
213 runs  201 ✅ 12 💤 0 ❌

Results for commit ea3b320.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Dec 11, 2024
@llrs-roche llrs-roche merged commit d3f3272 into main Dec 11, 2024
28 checks passed
@llrs-roche llrs-roche deleted the 335_man_links@main branch December 11, 2024 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK note
2 participants