Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation message; add renaming to the examples #362

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 17, 2025

before:

r$> lifecycle::deprecate_soft("0.6.1", "datanames()", details = "names()")
Warning message:
`datanames()` was deprecated in <NA> 0.6.1.
ℹ names()

after:

r$> lifecycle::deprecate_soft("0.6.1", "datanames()", with = "names()")
Warning message:
`datanames()` was deprecated in <NA> 0.6.1.
ℹ Please use `names()` instead.

Also updated docs to give example of reassigning names - previously done with datanames(x) <- ... which is deprecated now

@pawelru pawelru added the core label Jan 17, 2025
@pawelru pawelru enabled auto-merge (squash) January 17, 2025 08:56
Copy link
Contributor

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit 5cedae9.

Copy link
Contributor

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit 5cedae9.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice addition of the renaming example, I had to double check the last example as I expected names(td) <- to work.

@pawelru pawelru merged commit e32da6c into main Jan 20, 2025
28 checks passed
@pawelru pawelru deleted the fix_depr_msg branch January 20, 2025 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants