Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip vbump] upversion v0.7.0 #364

Merged
merged 6 commits into from
Jan 28, 2025
Merged

[skip vbump] upversion v0.7.0 #364

merged 6 commits into from
Jan 28, 2025

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Jan 28, 2025

Fixes #358

Summary

  • Update NEWS
  • Update DESCRIPTION
    • Temporary removal of Remotes
    • Upversion teal.code to 0.6.0
  • Update deprecation message to version 0.7.0
  • Update teal_data roxygen docs for missing links

@donyunardi donyunardi marked this pull request as ready for review January 28, 2025 00:23
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit 427e186.

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor Author

Got NOTE from R-devel:
https://github.com/insightsengineering/teal.data/actions/runs/12971170275/job/36177276243#step:8:109

Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  teal_data.Rd: qenv, within.qenv, get_code
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.

@donyunardi
Copy link
Contributor Author

@gogonzo gogonzo self-assigned this Jan 28, 2025
@llrs-roche
Copy link
Contributor

Got NOTE from R-devel: insightsengineering/teal.data/actions/runs/12971170275/job/36177276243#step:8:109

Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  teal_data.Rd: qenv, within.qenv, get_code
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.

If you have R-devel locally you can reproduce this check by setting the R envvar: _R_CHECK_XREFS_NOTE_MISSING_PACKAGE_ANCHORS_=TRUE
I think this is a blocking issue on CRAN.

According to the description on R internals: "If set to a true value, check whether Rd cross-references to targets not in the package itself or the base packages have package anchors."

@donyunardi donyunardi requested a review from gogonzo January 28, 2025 16:47
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@donyunardi
Copy link
Contributor Author

Submitted to CRAN. Awaiting feedback.

@donyunardi
Copy link
Contributor Author

Made it to CRAN:
#358 (comment)

@donyunardi donyunardi merged commit 29deac2 into main Jan 28, 2025
61 checks passed
@donyunardi donyunardi deleted the release-candidate-v0.7.0 branch January 28, 2025 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRAN Release]: 0.7.0
4 participants