Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify builds dependencies of extra-deps #1318

Merged
merged 4 commits into from
Jan 27, 2025
Merged

simplify builds dependencies of extra-deps #1318

merged 4 commits into from
Jan 27, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 23, 2025

Similar to https://github.com/insightsengineering/teal.modules.general/pull/830/files

Companion to that allows to use older MultiAssayExperiment and older SummarizedExperiment
More explanation in here insightsengineering/teal.slice#637 (comment)

insightsengineering/teal#1460
insightsengineering/teal.slice#637

@m7pr m7pr added the core label Jan 23, 2025
@m7pr m7pr marked this pull request as ready for review January 23, 2025 14:19
@m7pr
Copy link
Contributor Author

m7pr commented Jan 23, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Unit Tests Summary

    1 files     70 suites   1h 12m 2s ⏱️
  727 tests   614 ✅ 113 💤 0 ❌
1 987 runs  1 759 ✅ 228 💤 0 ❌

Results for commit b09daf0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $129.72$ $+3.96$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $744.84$ $+10.31$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $228.40$ $+2.50$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $176.25$ $+1.54$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $110.55$ $+1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $274.11$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $88.12$ $+1.53$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $127.04$ $+4.23$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $252.30$ $+2.16$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $201.34$ $+3.10$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $88.11$ $+4.41$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $66.56$ $+2.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $67.68$ $+2.98$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $95.91$ $+5.62$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $77.72$ $+2.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $74.41$ $+1.63$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $79.87$ $+1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💔 $60.19$ $+1.60$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $58.11$ $+1.06$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $131.73$ $-2.22$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $82.02$ $-1.04$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $95.55$ $-2.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $82.77$ $-1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $63.07$ $-1.58$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💚 $42.74$ $-1.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $67.33$ $+2.50$ $0$ $0$ $0$ $0$

Results for commit 578b556

♻️ This comment has been updated with latest results.

@m7pr m7pr requested a review from llrs-roche January 27, 2025 11:10
@m7pr
Copy link
Contributor Author

m7pr commented Jan 27, 2025

Hey @llrs-roche would you mind checking the PR? The last comment has a built where all required dependency strategies are passing : )

@llrs-roche llrs-roche self-assigned this Jan 27, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well:

image

@m7pr m7pr merged commit b02af52 into main Jan 27, 2025
27 checks passed
@m7pr m7pr deleted the ci_pipelines branch January 27, 2025 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants