Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot_with_settings.R #224

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Update plot_with_settings.R #224

merged 1 commit into from
Feb 14, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Feb 13, 2024

follow-up on review comment #223 (comment)

follow-up on #223

Signed-off-by: Pawel Rucki <[email protected]>
@pawelru pawelru requested a review from averissimo February 13, 2024 14:31
@pawelru pawelru enabled auto-merge (squash) February 13, 2024 14:32
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    57-152
R/get_dt_rows.R                  13      13  0.00%    43-55
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    12-132
R/plot_with_settings.R          382      21  94.50%   293-306, 365-366, 377-378, 628-629, 631, 633
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   84
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R              7       7  0.00%    18-24
TOTAL                          1245     493  60.40%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: f138211

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   10 suites   13s ⏱️
101 tests 101 ✅ 0 💤 0 ❌
208 runs  208 ✅ 0 💤 0 ❌

Results for commit f138211.

@pawelru pawelru merged commit 225c45a into main Feb 14, 2024
21 checks passed
@pawelru pawelru deleted the pawelru-patch-1 branch February 14, 2024 09:36
@averissimo averissimo self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants