Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the code chunks does not break because of warnings #1471

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 30, 2025

Part of vignette review insightsengineering/nestdevs-tasks#99

@vedhav
Copy link
Contributor Author

vedhav commented Jan 30, 2025

:D GitHub issues is down hence the url failure

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Tests Summary

  1 files   28 suites   10m 48s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit 3d93258.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_session_info 💔 $17.14$ $+1.00$ $0$ $0$ $0$ $0$
module_teal 💔 $130.87$ $+1.33$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_session_info 💔 $17.12$ $+1.00$ creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended

Results for commit c4f8c23

♻️ This comment has been updated with latest results.

@vedhav vedhav enabled auto-merge (squash) January 31, 2025 11:59
@vedhav vedhav merged commit bf10ee4 into main Jan 31, 2025
27 checks passed
@vedhav vedhav deleted the 99-vignette-review@main branch January 31, 2025 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants