Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette improvements #1481

Closed
wants to merge 2 commits into from
Closed

Vignette improvements #1481

wants to merge 2 commits into from

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Feb 4, 2025

Part of insightsengineering/nestdevs-tasks#99

Changes:

  • customizing-module-output.Rmd adds shinylive and restructure the example to showcase undecorated module earlier so it becomes easy to see what "decoration" is about and it also helps in migrating modules to "decoratable modules".
  • teal-as-a-module.Rmd becomes teal-as-a-shiny-module.Rmd to reduce the ambiguous usage of "module" which means "shiny module" and not "teal module" in this case.
  • creating-custom-modules.Rmd minor changes
  • Use Ascii apostrophe throughout the package

@vedhav vedhav added documentation Improvements or additions to documentation core labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Tests Summary

  1 files   28 suites   10m 31s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit f42680a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $133.75$ $-6.25$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💚 $53.26$ $-2.39$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💚 $43.10$ $-1.49$ $0$ $0$ $0$ $0$
shinytest2-landing_popup 💚 $48.11$ $-2.23$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $38.05$ $-1.55$ $0$ $0$ $0$ $0$
shinytest2-modules 💚 $41.03$ $-1.61$ $0$ $0$ $0$ $0$
shinytest2-reporter 💚 $68.34$ $-1.56$ $0$ $0$ $0$ $0$
shinytest2-teal_data_module 💚 $48.52$ $-1.33$ $0$ $0$ $0$ $0$

Results for commit f12eaf5

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor

Please wait on reviewing this until we're done with #1476

@vedhav
Copy link
Contributor Author

vedhav commented Feb 6, 2025

Closing in favor of #1476. These changes will be brought to that feature branch.

@vedhav vedhav closed this Feb 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants