Skip to content

Commit

Permalink
Address minitest deprecation warnings
Browse files Browse the repository at this point in the history
Signed-off-by: James Stocks <[email protected]>
  • Loading branch information
James Stocks committed Sep 30, 2020
1 parent afb2f0f commit 8a057ec
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions test/unit/connection_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
# We need to test run_command b/c run_command_via_connection is private.
winrm.run_command("test") do |data|
called = true
data.must_equal "testdata"
_(data).must_equal "testdata"
end
called.must_equal true
_(called).must_equal true
end
end

Expand Down
28 changes: 14 additions & 14 deletions test/unit/transport_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,47 +24,47 @@
let(:winrm) { cls.new({ host: "dummy", logger: Logger.new(STDERR, level: :info) }) }

it "can be instantiated (with valid config)" do
winrm.wont_be_nil
_(winrm).wont_be_nil
end

it "configures the host" do
winrm.options[:host].must_equal "dummy"
_(winrm.options[:host]).must_equal "dummy"
end

it "has default endpoint" do
winrm.options[:endpoint].must_be_nil
_(winrm.options[:endpoint]).must_be_nil
end

it "has default path set" do
winrm.options[:path].must_equal "/wsman"
_(winrm.options[:path]).must_equal "/wsman"
end

it "has default ssl set" do
winrm.options[:ssl].must_equal false
_(winrm.options[:ssl]).must_equal false
end

it "has default self_signed set" do
winrm.options[:self_signed].must_equal false
_(winrm.options[:self_signed]).must_equal false
end

it "has default rdp_port set" do
winrm.options[:rdp_port].must_equal 3389
_(winrm.options[:rdp_port]).must_equal 3389
end

it "has default winrm_transport set" do
winrm.options[:winrm_transport].must_equal :negotiate
_(winrm.options[:winrm_transport]).must_equal :negotiate
end

it "has default winrm_disable_sspi set" do
winrm.options[:winrm_disable_sspi].must_equal false
_(winrm.options[:winrm_disable_sspi]).must_equal false
end

it "has default winrm_basic_auth_only set" do
winrm.options[:winrm_basic_auth_only].must_equal false
_(winrm.options[:winrm_basic_auth_only]).must_equal false
end

it "has default user" do
winrm.options[:user].must_equal "administrator"
_(winrm.options[:user]).must_equal "administrator"
end
end

Expand All @@ -73,21 +73,21 @@
let(:connection) { winrm.connection }
it "without ssl genrates uri" do
conf[:host] = "dummy_host"
connection.uri.must_equal "winrm://administrator@http://dummy_host:5985/wsman:3389"
_(connection.uri).must_equal "winrm://administrator@http://dummy_host:5985/wsman:3389"
end

it "without ssl genrates uri" do
conf[:ssl] = true
conf[:host] = "dummy_host_ssl"
connection.uri.must_equal "winrm://administrator@https://dummy_host_ssl:5986/wsman:3389"
_(connection.uri).must_equal "winrm://administrator@https://dummy_host_ssl:5986/wsman:3389"
end
end

describe "options validation" do
let(:winrm) { cls.new(conf) }
it "raises an error when a non-supported winrm_transport is specificed" do
conf[:winrm_transport] = "invalid"
proc { winrm.connection }.must_raise Train::ClientError
_(proc { winrm.connection }).must_raise Train::ClientError
end
end
end

0 comments on commit 8a057ec

Please sign in to comment.