Fix tests for PhpUnit 8

inspirum · Mar 15, 2020 · 2740439 · 2740439
1 parent ae72daa
commit 2740439
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/tests/Unit/Balikobot/OrderShipmentTest.php b/tests/Unit/Balikobot/OrderShipmentTest.php
@@ -70,9 +70,6 @@ public function testMakeRequestWithDeprecatedParameter()
 
     public function testMakeRequestWithDeprecatedParameterWorks()
     {
-        $depracatedEnabled   = Deprecated::$enabled;
-        Deprecated::$enabled = false;
-
         $requester = $this->newRequesterWithMockedRequestMethod(200, [
             'status'       => 200,
             'order_id'     => 29,
@@ -89,7 +86,7 @@ public function testMakeRequestWithDeprecatedParameterWorks()
         $packages->add(new OrderedPackage(1, 'ppl', '0001', '1234'));
         $packages->add(new OrderedPackage(2, 'ppl', '0001', '5678'));
 
-        $service->orderShipment($packages, new DateTime('2018-10-10 10:00:00'));
+        @$service->orderShipment($packages, new DateTime('2018-10-10 10:00:00'));
 
         $requester->shouldHaveReceived(
             'request',
@@ -104,8 +101,6 @@ public function testMakeRequestWithDeprecatedParameterWorks()
         );
 
         $this->assertTrue(true);
-
-        Deprecated::$enabled = $depracatedEnabled;
     }
 
     public function testResponseData()
@@ -138,9 +133,6 @@ public function testResponseData()
 
     public function testResponseDataWithDepractedParameter()
     {
-        $depracatedEnabled   = Deprecated::$enabled;
-        Deprecated::$enabled = false;
-
         $requester = $this->newRequesterWithMockedRequestMethod(200, [
             'status'       => 200,
             'order_id'     => 29,
@@ -157,7 +149,7 @@ public function testResponseDataWithDepractedParameter()
         $packages->add(new OrderedPackage(1, 'ppl', '0001', '1234'));
         $packages->add(new OrderedPackage(2, 'ppl', '0001', '5678'));
 
-        $orderedShipment = $service->orderShipment($packages, new DateTime('2018-10-10 10:00:00'));
+        @$orderedShipment = $service->orderShipment($packages, new DateTime('2018-10-10 10:00:00'));
 
         $this->assertEquals('ppl', $orderedShipment->getShipper());
         $this->assertEquals([1, 2], $orderedShipment->getPackageIds());
@@ -166,7 +158,5 @@ public function testResponseDataWithDepractedParameter()
         $this->assertEquals('http://pdf.balikobot.cz/cp/eNoz0jW0XDBcMAHtXDDJ', $orderedShipment->getLabelsUrl());
         $this->assertEquals('http://pdf.balikobot.cz/cp/eNoz0jW0BfwwAe5cMMo.', $orderedShipment->getHandoverUrl());
         $this->assertEquals(29, $orderedShipment->getOrderId());
-
-        Deprecated::$enabled = $depracatedEnabled;
     }
 }
diff --git a/tests/Unit/Client/Requests/OrderRequestTest.php b/tests/Unit/Client/Requests/OrderRequestTest.php
@@ -87,16 +87,13 @@ public function testMakeRequestWithDeprecatedParameters()
 
     public function testMakeRequestWithDeprecatedParametersWorks()
     {
-        $depracatedEnabled   = Deprecated::$enabled;
-        Deprecated::$enabled = false;
-
         $requester = $this->newRequesterWithMockedRequestMethod(200, [
             'status' => 200,
         ]);
 
         $client = new Client($requester);
 
-        $client->orderShipment('cp', [1, 4], new DateTime('2018-10-10 14:00:00'), 'TEST');
+        @$client->orderShipment('cp', [1, 4], new DateTime('2018-10-10 14:00:00'), 'TEST');
 
         $requester->shouldHaveReceived(
             'request',
@@ -111,8 +108,6 @@ public function testMakeRequestWithDeprecatedParametersWorks()
         );
 
         $this->assertTrue(true);
-
-        Deprecated::$enabled = $depracatedEnabled;
     }
 
     public function testOnlyOrderDataAreReturned()