Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django: capture responseHeadersOnEntrySpans #489

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Django: capture responseHeadersOnEntrySpans #489

merged 3 commits into from
Jan 2, 2024

Conversation

GSVarsha
Copy link
Contributor

Django: capture responseHeadersOnEntrySpans

Signed-off-by: Varsha GS [email protected]

@GSVarsha GSVarsha self-assigned this Dec 28, 2023
@GSVarsha GSVarsha requested review from pvital and Ferenc- December 28, 2023 11:19
Ferenc-
Ferenc- reviewed Dec 29, 2023
View reviewed changes
tests/apps/app_django.py Outdated Show resolved Hide resolved
Ferenc-
Ferenc- requested changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have suggested a few minor changes.

@GSVarsha
- use unittest assert statements
8363101 
- capture a list of headers

Signed-off-by: Varsha GS <[email protected]>
@GSVarsha GSVarsha requested a review from Ferenc- December 29, 2023 13:03
Ferenc-
Ferenc- approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pvital
pvital approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 884edc3 into master Jan 2, 2024
12 checks passed
@GSVarsha GSVarsha deleted the django-header-capture branch January 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferenc- Ferenc- Ferenc- approved these changes

@pvital pvital pvital approved these changes

Assignees

@GSVarsha GSVarsha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSVarsha @pvital @Ferenc-