Capture custom HTTP headers (Part 2) #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varsha GS <[email protected]>
Signed-off-by: Varsha GS <[email protected]>
Signed-off-by: Varsha GS <[email protected]>
Signed-off-by: Varsha GS <[email protected]>
GSVarsha
force-pushed
the
capture_headers_part2
branch
2 times, most recently
from
f2086c7 to
0b0fbf6
Compare
GSVarsha
added
enhancement
Review & Merge
and removed
wip
GSVarsha
force-pushed
the
capture_headers_part2
branch
from
0b0fbf6 to
7c69cd8
Compare
Signed-off-by: Varsha GS <[email protected]>
GSVarsha
force-pushed
the
capture_headers_part2
branch
from
7c69cd8 to
51c705c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture custom HTTP headers (Part 2)
What?
aiohttp-client: 🟨 requestHeadersOnExitSpans
aiohttp-server: 🟨 responseHeadersOnEntrySpans
tornado-client: 🟥 requestHeadersOnExitSpans, responseHeadersOnExitSpans
wsgi: 🟨 responseHeadersOnEntrySpans
flask: 🟨 (needs request header testcase)
starlette: 🟨 (needs response header testcase)
Enhancement
Use a single common method to capture custom headers.