Propose simplifications to the SDG API design #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See instructlab/sdg#61 for some of the discussion on this, but I've tried to summarize those discussions in the design doc. Signed-off-by: Mark McLoughlin <[email protected]>
russellb
approved these changes
Jul 9, 2024
hickeyma
approved these changes
Jul 9, 2024
|
The direction of the proposal makes sense. |
3 tasks
|
There are 3 small changes proposed here:
2 and 3 have merged already 1 is at instructlab/sdg#64 |
|
@shivchander Do you mind reviewing this and providing your feedback? This would be great as you had a lot of input in instructlab/sdg#61 and with removing it in instructlab/sdg#61 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See instructlab/sdg#61 for some of the discussion on this, but I've tried to summarize those discussions in the design doc.