Batch support with vllm #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this PR on |
|
Thanks @russellb, let's hold on to the reviews, we are still testing the changes. Will request the review once it is ready. |
aakankshaduggal
force-pushed
the
batch-support-vllm
branch
2 times, most recently
from
6685898 to
5492d58
Compare
aakankshaduggal
force-pushed
the
batch-support-vllm
branch
2 times, most recently
from
59d4276 to
c973f95
Compare
Co-authored-by: Nikhil Palaskar <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: Aakanksha Duggal <[email protected]>
aakankshaduggal
force-pushed
the
batch-support-vllm
branch
from
c973f95 to
1182c80
Compare
oindrillac
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks @njhill @npalaska for adding batched VLLM support and @aakankshaduggal for testing this out
This was referenced Jul 11, 2024
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
PR instructlab#105 needs some new words added to the spelling dictionary. Signed-off-by: JJ Asghar <[email protected]>
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
…ling Update spelling per instructlab#105
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
Update knowledge-submissions-past-wikipedia.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds batch support with vllm