reduce number of arguments in openai_completion and openai_completion #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several functions passes trough six argument verbatim to OpenAI client creation. It causes to very long argument lists and increases technological debt. Pass OpenAI client object instead of those six arguments to reduce duplicated code and increase repeatability. TODO: perform the same optimization with generate_data and cli too. Signed-off-by: Costa Shulyupin <[email protected]>
|
Thanks for your contribution. However, I think now that #46 has merged, this code is no longer present? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions passes trough six argument verbatim to OpenAI client creation.
It causes to very long argument lists and increases technological debt.
Pass OpenAI client object instead of those six arguments to reduce
duplicated code and increase repeatability.
TODO: perform the same optimization with generate_data and cli too.
Signed-off-by: Costa Shulyupin [email protected]