Allow FilterByValueBlock to handle one or many values #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmc
reviewed
Jul 4, 2024
|
Great. Nice and simple, no confusion. lgtm |
|
This pull request has merge conflicts that must be resolved before it can be |
This block previously only accepted a single value to filter on. This update makes it handle a list, as well. In that case, it will ensure that the filter matches one of the values in the list. This is an updated implementation of the feature originally proposed in instructlab#72. Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
filterblock-multi-value
branch
from
6c1f3ee to
3e21ca8
Compare
|
I rebased this and marked it ready for review now that the pre-req PR merged. |
|
lgtm 👍 |
thanks for the review! |
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
Design for serving models with different backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
97d3fcd filterblock: Don't break when filtering on unexpected data
commit 6c1f3eee12d47bf4be7fa23282732d3c8a143028
Author: Russell Bryant [email protected]
Date: Wed Jul 3 21:28:56 2024 -0400