Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop remaining import from main instructlab package #89

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

russellb
Copy link
Member

@russellb russellb commented Jul 6, 2024

This was the last import from the main instructlab package to
remove. All it did was return this string constant, so just copy it
over.

Closes #11

Signed-off-by: Russell Bryant [email protected]

This was the last import from the main `instructlab` package to
remove. All it did was return this string constant, so just copy it
over.

Closes instructlab#11

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb added this to the 0.1.0 milestone Jul 8, 2024
Copy link
Contributor

@oindrillac oindrillac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aakankshaduggal aakankshaduggal merged commit 08938f3 into instructlab:main Jul 8, 2024
11 checks passed
jwm4 pushed a commit to jwm4/sdg that referenced this pull request Dec 13, 2024
add target to automatically fix markdown lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import functions from the ilab repository
4 participants